linux-kernel - Re: [PATCH v5 2/2] leds: lm3697: Introduce the lm3697 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <586dc4fb-ebdf-ba8a-8a1e-ad49c80a1157@gmail.com>
Date:   Fri, 24 Aug 2018 21:33:44 +0200
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Dan Murphy <dmurphy@...com>, Pavel Machek <pavel@....cz>
Cc:     robh+dt@...nel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org
Subject: Re: [PATCH v5 2/2] leds: lm3697: Introduce the lm3697 driver

Dan,

On 08/24/2018 01:58 PM, Dan Murphy wrote:
> Jacek
> 
> On 08/24/2018 05:05 AM, Pavel Machek wrote:
>> Hi!
>>
>>> +/**
>>> + * struct lm3697 -
>>> + * @enable_gpio - Hardware enable gpio
>>> + * @regulator - LED supply regulator pointer
>>> + * @client - Pointer to the I2C client
>>> + * @regmap - Devices register map
>>> + * @dev - Pointer to the devices device struct
>>> + * @lock - Lock for reading/writing the device
>>> + * @leds - Array of LED strings.
>>> + */
>>
>> extra .
>>
>>> +	ret = regmap_write(led->priv->regmap, brt_msb_reg, brt_val);
>>> +	if (ret) {
>>> +		dev_err(&led->priv->client->dev, "Cannot write MSB\n");
>>> +		goto out;
>>> +	}
>>> +out:
>>
>> I'd avoid this goto.
>>
>>> +static int lm3697_set_control_bank(struct lm3697 *priv)
>>> +{
>>> +	u8 control_bank_config = 0;
>>> +	struct lm3697_led *led;
>>> +	int ret, i;
>>> +
>>> +	led = &priv->leds[0];
>>> +	if (led->control_bank == LM3697_CONTROL_A)
>>> +		led = &priv->leds[1];
>>
>> I'd expect CONTROL_A to correspond to leds[0]...?
>>
>>> +	for (i = 0; i < LM3697_MAX_LED_STRINGS; i++) {
>>> +		if (led->hvled_strings[i] == LM3697_HVLED_ASSIGNMENT)
>>> +			control_bank_config |= 1 << i;
>>> +	}
>>
>> Extra {}s.
>>
>>> +	priv->regulator = devm_regulator_get(&priv->client->dev, "vled");
>>> +	if (IS_ERR(priv->regulator))
>>> +		priv->regulator = NULL;
>>
>> If vled regulator is specified in dt and _get fails, is it worth a
>> warning?
>>
>> 									Pavel
>>
> 
> Do you want v6 or a new patch on top?

Please submit v6.

-- 
Best regards,
Jacek Anaszewski