linux-kernel - Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180824201025.GB18715@roeck-us.net>
Date:   Fri, 24 Aug 2018 13:10:25 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Roland Dreier <roland@...estorage.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Ben Hutchings <ben.hutchings@...ethink.co.uk>,
        LKML <linux-kernel@...r.kernel.org>, stable@...r.kernel.org,
        matt@...eblueprint.co.uk, bp@...e.de,
        Andrew Morton <akpm@...ux-foundation.org>,
        Andy Lutomirski <luto@...capital.net>, luto@...nel.org,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>, bp@...en8.de,
        brgerst@...il.com, davej@...emonkey.org.uk, dvlasenk@...hat.com,
        "H. Peter Anvin" <hpa@...or.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Peter Zijlstra <peterz@...radead.org>,
        sai.praneeth.prakhya@...el.com, sds@...ho.nsa.gov,
        Thomas Gleixner <tglx@...utronix.de>, toshi.kani@...com,
        linux-efi@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
        Yazen.Ghannam@....com
Subject: Re: [PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only
 contains page frame numbers"

On Fri, Aug 24, 2018 at 01:04:09PM -0700, Roland Dreier wrote:
> > Ok, so what patch should be reverted?  I'm seeing other reports of
> > problems all around this same area, but I can't figure out exactly what
> > to do.
> 
> Are any of those reports public?  If so can you point me at them, I'm
> curious if the symptoms match up.
> 
> I don't think we want to revert anything.  I think you should pull in
> edc3b9129cec and at least the first three patches that Ben listed:
> 
> 21cdb6b56843 x86/mm: Page align the '_end' symbol to avoid pfn conversion bugs
> b61a76f8850d x86/efi: Map RAM into the identity page table for mixed mode
> 753b11ef8e92 x86/efi: Setup separate EFI page tables in kexec paths
> 
> the first patch takes a bit of massaging (mostly because some of it is
> already touched by 02ff2769edbc, which keeps the changes from
> edc3b9129cec, and so we can drop a good bit when applying).  The other
> three apply cleanly.
> 
> I'm currently testing that and can send you the state of my tree in a bit.
> 

Sounds great. I'll hold off with sending my RFT series and wait for your
test results. I think we'll also need d367cef0a7f0c6 ("x86/mm/pat: Fix
boot crash when 1GB pages are not supported by the CPU").

Thanks,
Guenter