linux-kernel - Re: [PATCH 4.4 018/107] x86/paravirt: Make native_save

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1535152080.2902.58.camel@codethink.co.uk>
Date:   Sat, 25 Aug 2018 00:08:00 +0100
From:   Ben Hutchings <ben.hutchings@...ethink.co.uk>
To:     Nick Desaulniers <ndesaulniers@...gle.com>
Cc:     stable@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
        "H. Peter Anvin" <hpa@...or.com>,
        Tom Stellar <tstellar@...hat.com>,
        Sedat Dilek <sedat.dilek@...il.com>,
        Juergen Gross <jgross@...e.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>, acme@...hat.com,
        akataria@...are.com, akpm@...ux-foundation.org,
        andrea.parri@...rulasolutions.com, ard.biesheuvel@...aro.org,
        aryabinin@...tuozzo.com, astrachan@...gle.com,
        boris.ostrovsky@...cle.com, brijesh.singh@....com,
        caoj.fnst@...fujitsu.com, geert@...ux-m68k.org,
        ghackmann@...gle.com, jan.kiszka@...mens.com,
        jarkko.sakkinen@...ux.intel.com, joe@...ches.com,
        jpoimboe@...hat.com, keescook@...gle.com,
        kirill.shutemov@...ux.intel.com, kstewart@...uxfoundation.org,
        linux-efi@...r.kernel.org, linux-kbuild@...r.kernel.org,
        manojgupta@...gle.com, mawilcox@...rosoft.com,
        michal.lkml@...kovi.net, mjg59@...gle.com, mka@...omium.org,
        pombredanne@...b.com, rientjes@...gle.com, rostedt@...dmis.org,
        thomas.lendacky@....com, tweek@...gle.com,
        virtualization@...ts.linux-foundation.org, will.deacon@....com,
        yamada.masahiro@...ionext.com, Ingo Molnar <mingo@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4.4 018/107] x86/paravirt: Make native_save_fl() extern
 inline

On Mon, 2018-07-23 at 14:41 +0200, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Nick Desaulniers <ndesaulniers@...gle.com>
> 
> commit d0a8d9378d16eb3c69bd8e6d23779fbdbee3a8c7 upstream.
> 
> native_save_fl() is marked static inline, but by using it as
> a function pointer in arch/x86/kernel/paravirt.c, it MUST be outlined.
> 
> paravirt's use of native_save_fl() also requires that no GPRs other than
> %rax are clobbered.
[...]

Shouldn't native_restore_fl() be changed similarly?  You added an out-
of-line definition, but it doesn't seem like it will actually be used.

Ben.

-- 
Ben Hutchings, Software Developer                         Codethink Ltd
https://www.codethink.co.uk/                 Dale House, 35 Dale Street
                                     Manchester, M1 2HF, United Kingdom