linux-kernel - Re: [PATCHv2 2/2] phy:phy-lantiq-rcu-usb2: Use PTR_ERR_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3de3eebf-4d28-5791-d0cf-e76290d630ce@hauke-m.de>
Date:   Sat, 25 Aug 2018 16:16:40 +0200
From:   Hauke Mehrtens <hauke@...ke-m.de>
To:     zhong jiang <zhongjiang@...wei.com>, alcooperx@...il.com,
        kishon@...com, robh@...nel.org, ralf@...ux-mips.org
Cc:     f.fainelli@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2 2/2] phy:phy-lantiq-rcu-usb2: Use PTR_ERR_OR_ZERO to
 replace the open coded version



On 08/16/2018 05:58 PM, zhong jiang wrote:
> PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So
> just replace them rather than duplicating its implement.
> 
> Signed-off-by: zhong jiang <zhongjiang@...wei.com>

Acked-by: Hauke Mehrtens <hauke@...ke-m.de>

> ---
>  drivers/phy/lantiq/phy-lantiq-rcu-usb2.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/phy/lantiq/phy-lantiq-rcu-usb2.c b/drivers/phy/lantiq/phy-lantiq-rcu-usb2.c
> index 986224f..a918c5b 100644
> --- a/drivers/phy/lantiq/phy-lantiq-rcu-usb2.c
> +++ b/drivers/phy/lantiq/phy-lantiq-rcu-usb2.c
> @@ -196,10 +196,8 @@ static int ltq_rcu_usb2_of_parse(struct ltq_rcu_usb2_priv *priv,
>  	}
>  
>  	priv->phy_reset = devm_reset_control_get_optional(dev, "phy");
> -	if (IS_ERR(priv->phy_reset))
> -		return PTR_ERR(priv->phy_reset);
>  
> -	return 0;
> +	return PTR_ERR_OR_ZERO(priv->phy_reset);
>  }
>  
>  static int ltq_rcu_usb2_phy_probe(struct platform_device *pdev)
>