linux-kernel - Re: [PATCH v2 21/32] selftests/ftrace: Add trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180826174331.58be4a6211236e81c9099821@kernel.org>
Date:   Sun, 26 Aug 2018 17:43:31 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Shuah Khan <shuah@...nel.org>, Ingo Molnar <mingo@...hat.com>,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 21/32] selftests/ftrace: Add trace_printk sample
 module test

On Fri, 24 Aug 2018 19:06:21 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Fri, 17 Aug 2018 01:39:06 +0900
> Masami Hiramatsu <mhiramat@...nel.org> wrote:
> 
> > Add trace_printk sample module test. This requires to
> > enable trace_printk.ko module for test.
> > 
> > Signed-off-by: Masami Hiramatsu <mhiramat@...nel.org>
> > ---
> >  .../selftests/ftrace/test.d/event/trace_printk.tc  |   27 ++++++++++++++++++++
> >  1 file changed, 27 insertions(+)
> >  create mode 100644 tools/testing/selftests/ftrace/test.d/event/trace_printk.tc
> > 
> > diff --git a/tools/testing/selftests/ftrace/test.d/event/trace_printk.tc b/tools/testing/selftests/ftrace/test.d/event/trace_printk.tc
> > new file mode 100644
> > index 000000000000..4da4d739f03d
> > --- /dev/null
> > +++ b/tools/testing/selftests/ftrace/test.d/event/trace_printk.tc
> > @@ -0,0 +1,27 @@
> > +#!/bin/sh
> > +# SPDX-License-Identifier: GPL-2.0
> > +# description: Test trace_printk from module
> > +
> > +rmmod trace-printk ||:
> > +if ! modprobe trace-printk.ko ; then
> 
> "modprobe trace-printk.ko" doesn't work. You need to drop the ".ko"

Ah, I'm using busybox's modprobe, which acccepts .ko :(

I'll fix that.

Thanks!

> 
> -- Steve
> 
> > +  echo "No trace-printk sample module - please make CONFIG_SAMPLE_TRACE_PRINTK=m"
> > +  exit_unresolved;
> > +fi
> > +
> > +echo "Waiting for irq work"
> > +sleep 1
> > +
> > +grep -q ": This .* trace_bputs" trace
> > +grep -q ": This .* trace_puts" trace
> > +grep -q ": This .* trace_bprintk" trace
> > +grep -q ": This .* trace_printk" trace
> > +
> > +grep -q ": (irq) .* trace_bputs" trace
> > +grep -q ": (irq) .* trace_puts" trace
> > +grep -q ": (irq) .* trace_bprintk" trace
> > +grep -q ": (irq) .* trace_printk" trace
> > +
> > +grep -q "This is a %s that will use trace_bprintk" printk_formats
> > +grep -q "(irq) This is a static string that will use trace_bputs" printk_formats
> > +
> > +rmmod trace-printk ||:
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>