linux-kernel - Re: [PATCHv3] Fix range checks in kernfs_get_target

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180827140317.GD3978217@devbig004.ftw2.facebook.com>
Date:   Mon, 27 Aug 2018 07:03:17 -0700
From:   Tejun Heo <tj@...nel.org>
To:     Bernd Edlinger <bernd.edlinger@...mail.de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv3] Fix range checks in kernfs_get_target_path

On Sun, Aug 26, 2018 at 10:55:24AM +0000, Bernd Edlinger wrote:
> Ping...
> Sorry, I had actually completely forgotten about this one.
> 
> On 07/07/18 19:52, Bernd Edlinger wrote:
> > The terminating NUL byte is only there because the buffer is
> > allocated with kzalloc(PAGE_SIZE, GFP_KERNEL), but since the
> > range-check is off-by-one, and PAGE_SIZE==PATH_MAX, the
> > returned string may not be zero-terminated if it is exactly
> > PATH_MAX characters long.  Furthermore also the initial loop
> > may theoretically exceed PATH_MAX and cause a fault.
> > 
> > Signed-off-by: Bernd Edlinger <bernd.edlinger@...mail.de>

Acked-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun