linux-kernel - Re: [PATCH] Staging: rtlwifi: efuse: fixed a line length coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 27 Aug 2018 19:51:08 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Tom Todd <thomas.m.a.todd@...il.com>
Cc:     Larry.Finger@...inger.net, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: rtlwifi: efuse: fixed a line length coding
 style issue

On Mon, Aug 13, 2018 at 10:11:21PM +0100, Tom Todd wrote:
> Fixed a code style issue. Line length over 80 characters.
> 
> Signed-off-by: Tom Todd <thomas.m.a.todd@...il.com>
> ---
>  drivers/staging/rtlwifi/efuse.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtlwifi/efuse.c b/drivers/staging/rtlwifi/efuse.c
> index 1dc71455f270..49ec9728fb04 100644
> --- a/drivers/staging/rtlwifi/efuse.c
> +++ b/drivers/staging/rtlwifi/efuse.c
> @@ -245,7 +245,8 @@ void read_efuse(struct ieee80211_hw *hw, u16 _offset, u16 _size_byte, u8 *pbuf)
>  	if (!efuse_word)
>  		goto out;
>  	for (i = 0; i < EFUSE_MAX_WORD_UNIT; i++) {
> -		efuse_word[i] = kcalloc(efuse_max_section, sizeof(u16), GFP_ATOMIC);
> +		efuse_word[i] =
> +			kcalloc(efuse_max_section, sizeof(u16), GFP_ATOMIC);

No, keep the kcalloc on the same line and just wrap any needed
parameters.

thanks,

greg k-h