linux-kernel - Re: [PATCH] mtd: rawnand: docg4: Remove wrong _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 27 Aug 2018 20:44:35 +0200
From:   Boris Brezillon <boris.brezillon@...tlin.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        Marek Vasut <marek.vasut@...il.com>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] mtd: rawnand: docg4: Remove wrong __init annotations

On Thu, 23 Aug 2018 23:43:45 +0200
Geert Uytterhoeven <geert@...ux-m68k.org> wrote:

> If gcc (e.g. 4.1.2) decides not to inline init_mtd_structs() and
> read_id_reg(), this will cause section mismatches, and crashes:
> 
>     WARNING: drivers/mtd/nand/raw/docg4.o(.text+0xc10): Section mismatch in reference from the function docg4_attach_chip() to the function .init.text:init_mtd_structs()
>     The function docg4_attach_chip() references
>     the function __init init_mtd_structs().
>     This is often because docg4_attach_chip lacks a __init
>     annotation or the annotation of init_mtd_structs is wrong.
> 
>     WARNING: drivers/mtd/nand/raw/docg4.o(.text+0xc3e): Section mismatch in reference from the function docg4_attach_chip() to the function .init.text:read_id_reg()
>     The function docg4_attach_chip() references
>     the function __init read_id_reg().
>     This is often because docg4_attach_chip lacks a __init
>     annotation or the annotation of read_id_reg is wrong.
> 
> Fix this by dropping the now incorrect __init annotations from
> init_mtd_structs() and read_id_reg().
> 
> Fixes: 66a38478dcc5b5a3 ("mtd: rawnand: docg4: convert driver to nand_scan()")
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Queued to mtd/master.

Thanks,

Boris

> ---
>  drivers/mtd/nand/raw/docg4.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/docg4.c b/drivers/mtd/nand/raw/docg4.c
> index a3f04315c05c54e6..427fcbc1b71c0551 100644
> --- a/drivers/mtd/nand/raw/docg4.c
> +++ b/drivers/mtd/nand/raw/docg4.c
> @@ -1218,7 +1218,7 @@ static int docg4_resume(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -static void __init init_mtd_structs(struct mtd_info *mtd)
> +static void init_mtd_structs(struct mtd_info *mtd)
>  {
>  	/* initialize mtd and nand data structures */
>  
> @@ -1290,7 +1290,7 @@ static void __init init_mtd_structs(struct mtd_info *mtd)
>  
>  }
>  
> -static int __init read_id_reg(struct mtd_info *mtd)
> +static int read_id_reg(struct mtd_info *mtd)
>  {
>  	struct nand_chip *nand = mtd_to_nand(mtd);
>  	struct docg4_priv *doc = nand_get_controller_data(nand);