linux-kernel - Re: [PATCH 4.4 018/107] x86/paravirt: Make native_save

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKwvOd=8rVG5L8dzE5v_jj6o3gruRStxF=orX4jA+tzB=gf2Vg@mail.gmail.com>
Date:   Mon, 27 Aug 2018 14:06:07 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     ben.hutchings@...ethink.co.uk
Cc:     stable@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
        hpa@...or.com, tstellar@...hat.com, sedat.dilek@...il.com,
        jgross@...e.com, Linus Torvalds <torvalds@...ux-foundation.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>, acme@...hat.com,
        akataria@...are.com, Andrew Morton <akpm@...ux-foundation.org>,
        andrea.parri@...rulasolutions.com,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Andrey Ryabinin <aryabinin@...tuozzo.com>,
        Alistair Strachan <astrachan@...gle.com>,
        boris.ostrovsky@...cle.com, brijesh.singh@....com,
        Cao jin <caoj.fnst@...fujitsu.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Greg Hackmann <ghackmann@...gle.com>,
        "J. Kiszka" <jan.kiszka@...mens.com>,
        jarkko.sakkinen@...ux.intel.com, joe@...ches.com,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Kees Cook <keescook@...gle.com>,
        "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        linux-efi@...r.kernel.org,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Manoj Gupta <manojgupta@...gle.com>, mawilcox@...rosoft.com,
        Michal Marek <michal.lkml@...kovi.net>, mjg59@...gle.com,
        Matthias Kaehlcke <mka@...omium.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        David Rientjes <rientjes@...gle.com>, rostedt@...dmis.org,
        thomas.lendacky@....com, Thiebaud Weksteen <tweek@...gle.com>,
        virtualization@...ts.linux-foundation.org,
        Will Deacon <will.deacon@....com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Ingo Molnar <mingo@...nel.org>,
        Greg KH <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4.4 018/107] x86/paravirt: Make native_save_fl() extern inline

On Fri, Aug 24, 2018 at 4:08 PM Ben Hutchings
<ben.hutchings@...ethink.co.uk> wrote:
>
> On Mon, 2018-07-23 at 14:41 +0200, Greg Kroah-Hartman wrote:
> > 4.4-stable review patch.  If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Nick Desaulniers <ndesaulniers@...gle.com>
> >
> > commit d0a8d9378d16eb3c69bd8e6d23779fbdbee3a8c7 upstream.
> >
> > native_save_fl() is marked static inline, but by using it as
> > a function pointer in arch/x86/kernel/paravirt.c, it MUST be outlined.
> >
> > paravirt's use of native_save_fl() also requires that no GPRs other than
> > %rax are clobbered.
> [...]
>
> Shouldn't native_restore_fl() be changed similarly?  You added an out-
> of-line definition, but it doesn't seem like it will actually be used.
>

Good catch, will send a patch with your reported by. Thank you for the report.
-- 
Thanks,
~Nick Desaulniers