linux-kernel - Re: [V2][PATCH net] tipc: fix the big/little endian issue in tipc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180827.152402.1358178279473378697.davem@davemloft.net>
Date:   Mon, 27 Aug 2018 15:24:02 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     Haiqing.Bai@...driver.com
Cc:     netdev@...r.kernel.org, jon.maloy@...csson.com,
        ying.xue@...driver.com, zhenbo.gao@...driver.com,
        linux-kernel@...r.kernel.org
Subject: Re: [V2][PATCH net] tipc: fix the big/little endian issue in
 tipc_dest

From: Haiqing Bai <Haiqing.Bai@...driver.com>
Date: Mon, 27 Aug 2018 09:32:26 +0800

> In function tipc_dest_push, the 32bit variables 'node' and 'port'
> are stored separately in uppper and lower part of 64bit 'value'.
> Then this value is assigned to dst->value which is a union like:
> union
> {
>   struct {
>     u32 port;
>     u32 node;
>   };
>   u64 value;
> }
> This works on little-endian machines like x86 but fails on big-endian
> machines.
> 
> The fix remove the 'value' stack parameter and even the 'value'
> member of the union in tipc_dest, assign the 'node' and 'port' member
> directly with the input parameter to avoid the endian issue.
> 
> Fixes: a80ae5306a73 ("tipc: improve destination linked list")
> 
> Signed-off-by: Zhenbo Gao <zhenbo.gao@...driver.com>
> Acked-by: Jon Maloy <jon.maloy@...csson.com>
> Signed-off-by: Haiqing Bai <Haiqing.Bai@...driver.com>

Applied and queued up for -stable.