linux-kernel - Re: [PATCH] regulator: bd71837: Remove duplicate assignment for n

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180827053430.GA2448@localhost.localdomain>
Date:   Mon, 27 Aug 2018 08:34:30 +0300
From:   Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
To:     Axel Lin <axel.lin@...ics.com>
Cc:     Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: bd71837: Remove duplicate assignment for
 n_voltages of LDO2

Thanks Axel,

On Fri, Aug 24, 2018 at 07:16:12PM +0800, Axel Lin wrote:
> Set it once is enough.
> Also move n_voltages close to volt_table for better readability.
> 
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
>  drivers/regulator/bd71837-regulator.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/regulator/bd71837-regulator.c b/drivers/regulator/bd71837-regulator.c
> index 0f8ac8dec3e1..9b5e1297902f 100644
> --- a/drivers/regulator/bd71837-regulator.c
> +++ b/drivers/regulator/bd71837-regulator.c
> @@ -388,10 +388,9 @@ static const struct regulator_desc bd71837_regulators[] = {
>  		.ops = &bd71837_ldo_regulator_nolinear_ops,
>  		.type = REGULATOR_VOLTAGE,
>  		.volt_table = &ldo_2_volts[0],
> +		.n_voltages = ARRAY_SIZE(ldo_2_volts),
>  		.vsel_reg = BD71837_REG_LDO2_VOLT,
>  		.vsel_mask = LDO2_MASK,
> -		.n_voltages = ARRAY_SIZE(ldo_2_volts),
> -		.n_voltages = BD71837_LDO2_VOLTAGE_NUM,
>  		.enable_reg = BD71837_REG_LDO2_VOLT,
>  		.enable_mask = BD71837_LDO_EN,
>  		.owner = THIS_MODULE,
> -- 
> 2.17.1
> 

This is how it should have been in the first place!

Br,
	Matti Vaittinen