linux-kernel - Re: [PATCH v2] dma: mic_x100_dma: use devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180827054652.GW2388@vkoul-mobl>
Date:   Mon, 27 Aug 2018 11:16:53 +0530
From:   Vinod <vkoul@...nel.org>
To:     Huang Shijie <sjhuang@...vatar.ai>
Cc:     sudeep.dutt@...el.com, ashutosh.dixit@...el.com,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] dma: mic_x100_dma: use devm_kzalloc to fix an issue

On 22-08-18, 10:40, Huang Shijie wrote:
> The following patch introduced an issue.
>     commit f6206f00d8c5 ("dmaengine: mic_x100_dma: use the new helper to simplify the code")
> 
> This issue is :
> 
> 	kfree(mic_dma_dev)
> 	.....
> 	dma_async_device_unregister(mic_dma_dev->device);
> 
> Free the memory, and use it again.
> 
> So use devm_kzalloc to allocate mic_dma_dev to fix it.
> 
> When the Devres try to release the resources, it will call release at the
> following order:
> 
> 	dma_async_device_unregister(mic_dma_dev->device);
> 	.....
> 	kfree(mic_dma_dev)

After fixing the subsystem name, applied thanks
-- 
~Vinod