linux-kernel - Re: [PATCH] blk-wbt: get back the missed wakeup from __wbt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5cd959f0-b40c-b6ac-c037-89f6cc670f47@oracle.com>
Date:   Tue, 28 Aug 2018 10:52:57 +0800
From:   "jianchao.wang" <jianchao.w.wang@...cle.com>
To:     Jens Axboe <axboe@...nel.dk>, Anchal Agarwal <anchalag@...n.com>
Cc:     fllinden@...zon.com,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] blk-wbt: get back the missed wakeup from __wbt_done

Hi Jens

On 08/27/2018 10:51 PM, Jens Axboe wrote:
>>> I cannot get the point of "since we can't rely on just being woken from the ->func handler
>>> we set".
>>> Do you mean there could be someone else could wake up this task ?
> Yeah, you don't know for a fact that the wbt wait queue is the only
> guy waking us up. Any sleep like this needs a loop. It was quite
> easy to reproduce for me, and as expected, you'll get list corruption
> on the wait queue since we leave it on the list and the stack goes
> away.
> 
Yes, got it. Thanks for your kindly response. :)

Thanks
Jianchao