linux-kernel - Re: [PATCH] checkpatch: Add __ro_after

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jKCyzqcrTj8h9jvv6_ZMcKQ4=K8BjP6MrcgaUzA1cqYbg@mail.gmail.com>
Date:   Mon, 27 Aug 2018 22:44:33 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Joe Perches <joe@...ches.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Andy Whitcroft <apw@...onical.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] checkpatch: Add __ro_after_init to known $Attribute

On Mon, Aug 27, 2018 at 10:33 PM, Joe Perches <joe@...ches.com> wrote:
> __ro_after_init is a specific __attribute__ that checkpatch
> does currently not understand.
>
> Add it to the known $Attribute types so that code that uses
> variables declared with __ro_after_init are not thought to
> be a modifier type.
>
> This appears as a defect in checkpatch output of code like:
>
> static bool trust_cpu __ro_after_init = IS_ENABLED(CONFIG_RANDOM_TRUST_CPU);
> [...]
>        if (trust_cpu && arch_init) {
>
> where checkpatch reports:
>
> ERROR: space prohibited after that '&&' (ctx:WxW)
>         if (trust_cpu && arch_init) {
>

Thanks for tracking this down!

> Reported-by: Kees Cook <keescook@...omium.org>
> Signed-off-by: Joe Perches <joe@...ches.com>

Tested-by: Kees Cook <keescook@...omium.org>

-Kees

> ---
>  scripts/checkpatch.pl | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 5219280bf7ff..23cde9d90278 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -380,6 +380,7 @@ our $Attribute      = qr{
>                         __noclone|
>                         __deprecated|
>                         __read_mostly|
> +                       __ro_after_init|
>                         __kprobes|
>                         $InitAttribute|
>                         ____cacheline_aligned|



-- 
Kees Cook
Pixel Security