linux-kernel - Re: [PATCH v5 6/6] soc: qcom: Allow COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 28 Aug 2018 17:37:51 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Niklas Cassel <niklas.cassel@...aro.org>
Cc:     kbuild-all@...org, Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        Niklas Cassel <niklas.cassel@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 6/6] soc: qcom: Allow COMPILE_TEST of qcom SoC Kconfigs

Hi Niklas,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on agross/for-next]
[also build test WARNING on v4.19-rc1 next-20180828]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Niklas-Cassel/soc-qcom-Allow-COMPILE_TEST-of-qcom-SoC-Kconfigs/20180827-195255
base:   https://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git for-next
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 8.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=8.1.0 make.cross ARCH=ia64 

All warnings (new ones prefixed by >>):

   drivers//soc/qcom/wcnss_ctrl.c: In function 'qcom_wcnss_open_channel':
>> drivers//soc/qcom/wcnss_ctrl.c:284:2: warning: 'strncpy' specified bound 32 equals destination size [-Wstringop-truncation]
     strncpy(chinfo.name, name, sizeof(chinfo.name));
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
--
   In function 'apr_add_device',
       inlined from 'of_register_apr_devices' at drivers//soc/qcom/apr.c:264:7,
       inlined from 'apr_probe' at drivers//soc/qcom/apr.c:290:2:
>> drivers//soc/qcom/apr.c:222:3: warning: 'strncpy' specified bound 32 equals destination size [-Wstringop-truncation]
      strncpy(adev->name, np->name, APR_NAME_SIZE);
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/strncpy +284 drivers//soc/qcom/wcnss_ctrl.c

6be2b3d0 Bjorn Andersson 2016-06-06  272  
6be2b3d0 Bjorn Andersson 2016-06-06  273  /**
6be2b3d0 Bjorn Andersson 2016-06-06  274   * qcom_wcnss_open_channel() - open additional SMD channel to WCNSS
6be2b3d0 Bjorn Andersson 2016-06-06  275   * @wcnss:	wcnss handle, retrieved from drvdata
6be2b3d0 Bjorn Andersson 2016-06-06  276   * @name:	SMD channel name
6be2b3d0 Bjorn Andersson 2016-06-06  277   * @cb:		callback to handle incoming data on the channel
6be2b3d0 Bjorn Andersson 2016-06-06  278   */
5052de8d Bjorn Andersson 2017-03-27  279  struct rpmsg_endpoint *qcom_wcnss_open_channel(void *wcnss, const char *name, rpmsg_rx_cb_t cb, void *priv)
6be2b3d0 Bjorn Andersson 2016-06-06  280  {
5052de8d Bjorn Andersson 2017-03-27  281  	struct rpmsg_channel_info chinfo;
6be2b3d0 Bjorn Andersson 2016-06-06  282  	struct wcnss_ctrl *_wcnss = wcnss;
6be2b3d0 Bjorn Andersson 2016-06-06  283  
5052de8d Bjorn Andersson 2017-03-27 @284  	strncpy(chinfo.name, name, sizeof(chinfo.name));
5052de8d Bjorn Andersson 2017-03-27  285  	chinfo.src = RPMSG_ADDR_ANY;
5052de8d Bjorn Andersson 2017-03-27  286  	chinfo.dst = RPMSG_ADDR_ANY;
5052de8d Bjorn Andersson 2017-03-27  287  
5052de8d Bjorn Andersson 2017-03-27  288  	return rpmsg_create_ept(_wcnss->channel->rpdev, cb, priv, chinfo);
6be2b3d0 Bjorn Andersson 2016-06-06  289  }
6be2b3d0 Bjorn Andersson 2016-06-06  290  EXPORT_SYMBOL(qcom_wcnss_open_channel);
6be2b3d0 Bjorn Andersson 2016-06-06  291  

:::::: The code at line 284 was first introduced by commit
:::::: 5052de8deff5619a9b7071f00084fd0264b58e17 soc: qcom: smd: Transition client drivers from smd to rpmsg

:::::: TO: Bjorn Andersson <bjorn.andersson@...aro.org>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (50959 bytes)