linux-kernel - Re: [PATCH v3 2/2]: perf record: enable asynchronous trace writing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2ed75413-4a8a-ee0c-be27-b3fbbfa000c6@linux.intel.com>
Date:   Tue, 28 Aug 2018 15:37:45 +0300
From:   Alexey Budankov <alexey.budankov@...ux.intel.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Andi Kleen <ak@...ux.intel.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/2]: perf record: enable asynchronous trace writing

Hi,

On 28.08.2018 12:01, Jiri Olsa wrote:
> On Mon, Aug 27, 2018 at 09:16:55PM +0300, Alexey Budankov wrote:
> 
> SNIP
> 
>> +static int record__mmap_read_sync(int trace_fd, struct aiocb **cblocks,
>> +		int cblocks_size, struct record *rec)
>> +{
>> +	size_t rem;
>> +	ssize_t size;
>> +	off_t rem_off;
>> +	int i, aio_ret, aio_errno, do_suspend;
>> +	struct perf_mmap *md;
>> +	struct timespec timeout0 = { 0, 0 };
>> +	struct timespec timeoutS = { 0, 1000 * 500  * 1 }; // 0.5ms
>> +
>> +	if (!cblocks_size)
>> +		return 0;
>> +
>> +	do {
>> +		do_suspend = 0;
>> +		/* aio_suspend() implementation inside glibc (as of v2.27) is
>> +		 * intrusive and not just blocks waiting io requests completion
>> +		 * but polls requests queue inducing context switches in perf
>> +		 * tool process. When profiling in system wide mode with tracing
>> +		 * context switches the trace may be polluted by context switches
>> +		 * from the perf process and the trace size becomes about 3-5
>> +		 * times bigger than that of when writing the trace serially.
>> +		 * To limit the volume of context switches from perf tool
>> +		 * process nanosleep() call below is added prior aio_suspend()
>> +		 * calling till every half of the kernel timer tick which is
>> +		 * usually 1ms (depends on CONFIG_HZ value).
> 
> nice, any idea this is intentional for some reason?
> 
> was there some impact on the overall performance or
> this is purely for the sanity of the trace size?

Initially we noticed the trace size increase only. However if you look at 
the data using perf report you see that Perf tool process gets considerable 
volume of new context switches and that is what caused by switching 
to AIO streaming, specifically frequent calls of aio_suspend().

> 
> thanks,
> jirka
>