linux-kernel - Re:Re: [PATCH v2] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <749634d5.bb6a.16580e444f2.Coremail.liuxiang_1999@126.com>
Date:   Tue, 28 Aug 2018 22:16:08 +0800 (CST)
From:   "Liu Xiang" <liuxiang_1999@....com>
To:     "Boris Brezillon" <boris.brezillon@...tlin.com>
Cc:     "Liu Xiang" <liu.xiang6@....com.cn>, linux-mtd@...ts.infradead.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        han.xu@....com, marek.vasut@...il.com, dwmw2@...radead.org,
        computersforpeace@...il.com, richard@....at
Subject: Re:Re: [PATCH v2] mtd: spi-nor: fsl-quadspi: fix read error for
 flash size  larger than 16MB



Thanks for your suggestion. Should I send another patch?







At 2018-08-28 21:23:05, "Boris Brezillon" <boris.brezillon@...tlin.com> wrote:
>On Tue, 28 Aug 2018 21:21:16 +0800
>Liu Xiang <liu.xiang6@....com.cn> wrote:
>
>> If the size of spi-nor flash is larger than 16MB, the read_opcode
>> is set to SPINOR_OP_READ_1_1_4_4B, and fsl_qspi_get_seqid() will
>> return -EINVAL when cmd is SPINOR_OP_READ_1_1_4_4B. This can
>> cause read operation fail.
>> 
>> ---
>> v2:
>>   add Fixes tag and CC stable suggested by Boris.
>> ---
>
>The above changelog
>
>> 
>> Fixes: e46ecda764dc ("mtd: spi-nor: Add Freescale QuadSPI driver")
>> Cc: <stable@...r.kernel.org>
>> Signed-off-by: Liu Xiang <liu.xiang6@....com.cn>
>> ---
>
>should be placed here.
>
>>  drivers/mtd/spi-nor/fsl-quadspi.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
>> index 7d9620c..64304a3 100644
>> --- a/drivers/mtd/spi-nor/fsl-quadspi.c
>> +++ b/drivers/mtd/spi-nor/fsl-quadspi.c
>> @@ -478,6 +478,7 @@ static int fsl_qspi_get_seqid(struct fsl_qspi *q, u8 cmd)
>>  {
>>  	switch (cmd) {
>>  	case SPINOR_OP_READ_1_1_4:
>> +	case SPINOR_OP_READ_1_1_4_4B:
>>  		return SEQID_READ;
>>  	case SPINOR_OP_WREN:
>>  		return SEQID_WREN;