linux-kernel - Re: [PATCH v2 1/2] rtc: mips: default to rtc-cmos on mips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180828163941.ztftznl7q4745u7f@pburton-laptop>
Date:   Tue, 28 Aug 2018 09:39:41 -0700
From:   Paul Burton <paul.burton@...s.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     linux-rtc@...r.kernel.org, a.zummo@...ertech.it,
        alexandre.belloni@...tlin.com, keguang.zhang@...il.com,
        y2038@...ts.linaro.org, Ralf Baechle <ralf@...ux-mips.org>,
        James Hogan <jhogan@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Matt Redfearn <matt.redfearn@...s.com>,
        Zubair Lutfullah Kakakhel <Zubair.Kakakhel@...tec.com>,
        linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] rtc: mips: default to rtc-cmos on mips

Hi Arnd,

On Tue, Aug 28, 2018 at 04:26:30PM +0200, Arnd Bergmann wrote:
> The old rtc driver is getting in the way of some compat_ioctl
> simplification. Looking up the loongson64 git history, it seems
> that everyone uses the more modern but compatible RTC_CMOS driver
> anyway, so let's remove the special case for loongson64.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  arch/mips/Kconfig    | 2 +-
>  drivers/char/Kconfig | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Looks good to me - history suggests Loongson's RTC needs to use binary
mode for some reason but we've had that support for a while.

Presuming you want this to go through the RTC tree:

    Acked-by: Paul Burton <paul.burton@...s.com>

Thanks,
    Paul