linux-kernel - Re: [PATCH v2 2/3] ata: libahci_platform: add reset control support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180829003418.GA18849@bogus>
Date:   Tue, 28 Aug 2018 19:34:18 -0500
From:   Rob Herring <robh@...nel.org>
To:     Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
Cc:     Tejun Heo <tj@...nel.org>, Hans de Goede <hdegoede@...hat.com>,
        Mark Rutland <mark.rutland@....com>, linux-ide@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Thierry Reding <thierry.reding@...il.com>
Subject: Re: [PATCH v2 2/3] ata: libahci_platform: add reset control support

On Wed, Aug 22, 2018 at 09:13:02PM +0900, Kunihiko Hayashi wrote:
> Add support to get and control a list of resets for the device
> as optional and shared. These resets must be kept de-asserted until
> the device is enabled.
> 
> This is specified as shared because some SoCs like UniPhier series
> have common reset controls with all ahci controller instances.
> 
> However, according to Thierry's view,
> https://www.spinics.net/lists/linux-ide/msg55357.html
> some hardware-specific drivers already use their own resets,
> and the common reset make a path to occur double controls of resets.
> 
> The ahci_platform_get_resources() can get and control the reset
> only when the second argument includes AHCI_PLATFORM_GET_RESETS bit.
> 
> Suggested-by: Hans de Goede <hdegoede@...hat.com>
> Cc: Thierry Reding <thierry.reding@...il.com>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
> ---
>  .../devicetree/bindings/ata/ahci-platform.txt      |  1 +

Acked-by: Rob Herring <robh@...nel.org>

>  drivers/ata/ahci.h                                 |  1 +
>  drivers/ata/libahci_platform.c                     | 31 ++++++++++++++++++----
>  include/linux/ahci_platform.h                      |  2 ++
>  4 files changed, 30 insertions(+), 5 deletions(-)