linux-kernel - Re: [PATCH] clk: ti: fix OF child-node lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180829075007.GC28861@localhost>
Date:   Wed, 29 Aug 2018 09:50:07 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Stephen Boyd <sboyd@...nel.org>
Cc:     Johan Hovold <johan@...nel.org>, Tero Kristo <t-kristo@...com>,
        Michael Turquette <mturquette@...libre.com>,
        linux-omap@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: ti: fix OF child-node lookup

On Tue, Aug 28, 2018 at 03:32:03PM -0700, Stephen Boyd wrote:
> Quoting Johan Hovold (2018-08-22 02:03:19)
> > Fix child-node lookup which by using the wrong OF helper was searching
> > the whole tree depth-first, something which could end up matching an
> > unrelated node.
> > 
> > Also fix the related node-reference leaks.
> > 
> > Fixes: 5b385a45e001 ("clk: ti: add support for clkctrl aliases")
> 
> Found by inspection? Or it's actively causing problems? I'm thinking
> it's the former so this can bake in clk-next for a while.

Right, through inspection. I fixed up most of these last year, but this
one managed to sneak in since then.

clk-next should be fine.

Thanks,
Johan