linux-kernel - RE: [PATCH 1/1] Preventive patch in the pin control subsystem to handle NULL check.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180829102543epcms5p2070c1c13edc239aa3f776f53b584c27a@epcms5p2>
Date:   Wed, 29 Aug 2018 15:55:43 +0530
From:   Srikanth Korangala Hari <srikanth.h@...sung.com>
To:     "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Srikanth Korangala Hari <srikanth.h@...sung.com>
Subject: RE: [PATCH 1/1] Preventive patch in the pin control subsystem to
 handle NULL check.

> If the pin descriptor requested for the physical pin fails then the
> descriptor is dereferenced without checking for its validity which
> may lead to crash, hence added preventive code to check for NULL
> and accordingly dereference.
 
> Signed-off-by: Srikanth K H <srikanth.h@...sung.com>
> ---
> drivers/pinctrl/pinconf.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
 
> diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
> index d3fe143..576d08d 100644
> --- a/drivers/pinctrl/pinconf.c
> +++ b/drivers/pinctrl/pinconf.c
> @@ -269,8 +269,9 @@ void pinconf_show_setting(struct seq_file *s,
>         case PIN_MAP_TYPE_CONFIGS_PIN:
>                 desc = pin_desc_get(setting->pctldev,
>                                     setting->data.configs.group_or_pin);
> -                seq_printf(s, "pin %s (%d)", desc->name,
> -                           setting->data.configs.group_or_pin);
> +                if (desc)
> +                        seq_printf(s, "pin %s (%d)", desc->name,
> +                                   setting->data.configs.group_or_pin);
>                 break;
>         case PIN_MAP_TYPE_CONFIGS_GROUP:
>                 seq_printf(s, "group %s (%d)",

Dear Maintainer's,

Please confirm me whether the above patch is considered for merging onto mainline ?

Thanks,
Srikanth