linux-kernel - Re: [PATCH net-next v2 0/2] dpaa2-eth: Move DPAA2 Ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 29 Aug 2018 14:07:39 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Ioana Radulescu <ruxandra.radulescu@....com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        devel@...verdev.osuosl.org, andrew@...n.ch, horia.geanta@....com,
        madalin.bucur@....com, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, ioana.ciornei@....com,
        laurentiu.tudor@....com
Subject: Re: [PATCH net-next v2 0/2] dpaa2-eth: Move DPAA2 Ethernet driver

There are a few static checker warnings for the driver but only the
first one looks like a possibly real bug.

drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c:1116 dpaa2_eth_stop() error: uninitialized symbol 'dpni_enabled'.
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c:1671 set_fq_affinity() warn: 'xps_mask' puts 1024 bytes on stack
drivers/staging/fsl-dpaa2/ethsw/ethsw.c:742 port_vlans_add() error: uninitialized symbol 'err'.
drivers/staging/fsl-dpaa2/ethsw/ethsw.c:886 port_vlans_del() error: uninitialized symbol 'err'.

regards,
dan carpenter