linux-kernel - Re: [perf] perf_event.h ABI visibility question

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180829121349.GT24124@hirez.programming.kicks-ass.net>
Date:   Wed, 29 Aug 2018 14:13:49 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Vince Weaver <vincent.weaver@...ne.edu>
Cc:     linux-kernel@...r.kernel.org, Josh Poimboeuf <jpoimboe@...hat.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Andy Lutomirski <luto@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Stephane Eranian <eranian@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>
Subject: Re: [perf] perf_event.h ABI visibility question

On Tue, Aug 28, 2018 at 01:51:29PM -0400, Vince Weaver wrote:
> On Mon, 27 Aug 2018, Peter Zijlstra wrote:
> 
> > Something like so then?
> > 
> > diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
> > index eeb787b1c53c..f35eb72739c0 100644
> > --- a/include/uapi/linux/perf_event.h
> > +++ b/include/uapi/linux/perf_event.h
> > @@ -144,7 +144,7 @@ enum perf_event_sample_format {
> >  
> >  	PERF_SAMPLE_MAX = 1U << 20,		/* non-ABI */
> >  
> > -	__PERF_SAMPLE_CALLCHAIN_EARLY		= 1ULL << 63,
> > +	__PERF_SAMPLE_CALLCHAIN_EARLY		= 1ULL << 63, /* non-ABI; internal use */
> >  };
> 
> yes, something like that would be fine.
> 
> I am being difficult about this, but from experience when trying to keep 
> the manpage updated, what seems obvious now will not be so obvious 6 
> months from now and trying to dig through the git logs / mailing list 
> archives to verify the purpose of an addition can be a lot of work 
> sometimes.

Yeah, no worries. I appreciate you paying attention to these things.