linux-kernel - Re: [Y2038] [RFC PATCH] y2038: __get_old

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 29 Aug 2018 15:17:35 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Fengguang Wu <fengguang.wu@...el.com>
Cc:     linux-arch <linux-arch@...r.kernel.org>,
        y2038 Mailman List <y2038@...ts.linaro.org>,
        Linux API <linux-api@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        kbuild-all@...org, Thomas Gleixner <tglx@...utronix.de>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Christoph Hellwig <hch@....de>,
        Deepa Dinamani <deepa.kernel@...il.com>
Subject: Re: [Y2038] [RFC PATCH] y2038: __get_old_timespec32() can be static

On Wed, Aug 29, 2018 at 2:52 PM kbuild test robot
<fengguang.wu@...el.com> wrote:
>
>
> Fixes: ee16c8f415e4 ("y2038: Globally rename compat_time to old_time32")
> Signed-off-by: kbuild test robot <fengguang.wu@...el.com>
> ---
>  time.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/time/time.c b/kernel/time/time.c
> index f1983f4..e3a7f7f 100644
> --- a/kernel/time/time.c
> +++ b/kernel/time/time.c
> @@ -863,7 +863,7 @@ int put_timespec64(const struct timespec64 *ts,
>  }
>  EXPORT_SYMBOL_GPL(put_timespec64);
>
> -int __get_old_timespec32(struct timespec64 *ts64,
> +static int __get_old_timespec32(struct timespec64 *ts64,
>                                    const struct old_timespec32 __user *cts)
>  {

This was caused by an older patch and we already get the same
warning in mainline linux, the bot triggered again after I renamed
it. Anyway, the fix is good, and I'll come up with a proper changelog
to include it in my series.

      Arnd