linux-kernel - Re: [PATCH 0/4] lightnvm: pblk: collection of small fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 29 Aug 2018 13:27:43 +0000
From:   Javier Gonzalez <javier@...xlabs.com>
To:     Matias Bjørling <mb@...htnvm.io>
CC:     "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/4] lightnvm: pblk: collection of small fixes


> On 29 Aug 2018, at 15.14, Matias Bjørling <mb@...htnvm.io> wrote:
> 
> On 08/29/2018 11:01 AM, Javier González wrote:
>> Collection of small helper function fixes, removal of unused variables
>> and comment typos.
>> Javier González (4):
>>   lightnvm: pblk: calculate line pad distance in helper
>>   lightnvm: pblk: fix comment typo
>>   lightnvm: pblk: remove unused variable.
>>   lightnvm: pblk: guarantee emeta on line close
>>  drivers/lightnvm/pblk-core.c     | 13 +++++++++++--
>>  drivers/lightnvm/pblk-recovery.c |  2 --
>>  drivers/lightnvm/pblk-write.c    |  2 +-
>>  drivers/lightnvm/pblk.h          |  6 +++---
>>  4 files changed, 15 insertions(+), 8 deletions(-)
> 
> Thanks. Applied 2-4. The pad distance does not compile due to missing
> update to pblk_pad_distance call from pblk-recovery.c.
> 
> Also, it looks like pblk-recovery.c is the only user. Please consider
> moving it the function from pblk.h to pblk-recovery.c

I reordered to send the helpers, but you can see that all these are made
to support.

  lightnvm: pblk: recover open lines on 2.0 devices

Can you fix this directly and apply 1 too? I'm fine with moving it to
pblk-recovery.c. The patch above will use it.

Thanks,
Javier

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)