linux-kernel - Re: [PATCH] power: supply: remove unused pointer 'dev'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180829141520.vaiuepmjdvizzhh2@mwanda>
Date:   Wed, 29 Aug 2018 17:15:20 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        Sameer Nanda <snanda@...omium.org>
Cc:     colin.king@...onical.com, sre@...nel.org, linux-pm@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: supply: remove unused pointer 'dev'

On Wed, Aug 29, 2018 at 03:54:13PM +0200, Krzysztof Kozlowski wrote:
> On Tue, 28 Aug 2018 at 18:29, Colin King <colin.king@...onical.com> wrote:
> >
> > From: Colin Ian King <colin.king@...onical.com>
> >
> > Pointer 'dev' is being assigned but is never used hence it is
> > redundant and can be removed.
> >
> > Cleans up clang warning:
> > variable 'dev' set but not used [-Wunused-but-set-variable]
> >
> > Signed-off-by: Colin Ian King <colin.king@...onical.com>
> > ---
> >  drivers/power/supply/cros_usbpd-charger.c | 2 --
> >  1 file changed, 2 deletions(-)
> >
> 
> Maybe add cros_usbpd prefix to the subject?
> 

Yeah.

The problem is that the prefix wasn't added to the subject in the
original commit f68b883e8fad ("power: supply: add cros-ec USBPD charger
driver.") which added the driver.  It's a common problem.  Normally what
happens is that someone adds a driver and then random static checker
people like Colin or I send the first fixes and we have no idea what the
correct prefix should be.  Anyway, checking the prefix is one of the
things we should look for when people add a new driver.

Also Colin you should CC Sameer because it's really his code.  Someone
should fix get_maintainer.pl so that it does git blame on the
lines before and after and adds people if the code is less than two
years old maybe.

regards,
dan carpenter