linux-kernel - [PATCH 0/4] tty: Hold write ldisc sem in tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180829022353.23568-1-dima@arista.com>
Date:   Wed, 29 Aug 2018 03:23:49 +0100
From:   Dmitry Safonov <dima@...sta.com>
To:     linux-kernel@...r.kernel.org
Cc:     Dmitry Safonov <0x7f454c46@...il.com>,
        Dmitry Safonov <dima@...sta.com>,
        Daniel Axtens <dja@...ens.net>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Michael Neuling <mikey@...ling.org>,
        Mikulas Patocka <mpatocka@...hat.com>,
        Pasi Kärkkäinen <pasik@....fi>,
        Peter Hurley <peter@...leysoftware.com>,
        Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        Tan Xiaojun <tanxiaojun@...wei.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>, stable@...r.kernel.org
Subject: [PATCH 0/4] tty: Hold write ldisc sem in tty_reopen()

Two fixes for potential and real issues.
Looks worth to have in stables as we've hit it on v4.9 stable.
And for linux-next - adding lockdep asserts for line discipline changing
code, verifying that write ldisc sem will be held forthwith.

I couldn't verify that holding write lock fixes the issue as we've hit
it only once and I've failed in reproducing it.
But searching in lkml, Cc'ing here people who probably had the same
crash (and in hope someone of them could give tested-by):

Cc: Daniel Axtens <dja@...ens.net> 
Cc: Dmitry Vyukov <dvyukov@...gle.com> 
Cc: Michael Neuling <mikey@...ling.org>
Cc: Mikulas Patocka <mpatocka@...hat.com>
Cc: Pasi Kärkkäinen <pasik@....fi>
Cc: Peter Hurley <peter@...leysoftware.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@...il.com> 
Cc: Tan Xiaojun <tanxiaojun@...wei.com>
(please, ignore if I Cc'ed you mistakenly)

Dmitry Safonov (4):
  tty: Drop tty->count on tty_reopen() failure
  tty: Hold tty_ldisc_lock() during tty_reopen()
  tty: Lock tty pair in tty_init_dev()
  tty/lockdep: Add ldisc_sem asserts

 drivers/tty/tty_io.c    | 21 +++++++++++++++------
 drivers/tty/tty_ldisc.c | 12 ++++++++----
 include/linux/tty.h     |  4 ++++
 3 files changed, 27 insertions(+), 10 deletions(-)

-- 
2.13.6