linux-kernel - Re: [PATCH v5 1/4] staging: mt7621-mmc: Remove commented code for N

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180829171215.GA8071@nishad>
Date:   Wed, 29 Aug 2018 22:42:16 +0530
From:   Nishad Kamdar <nishadkamdar@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Joe Perches <joe@...ches.com>, NeilBrown <neil@...wn.name>,
        devel@...verdev.osuosl.org,
        Christian Lütke-Stetzkamp <christian@...mp.de>,
        linux-kernel@...r.kernel.org, John Crispin <blogic@...nwrt.org>,
        Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH v5 1/4] staging: mt7621-mmc: Remove commented code for
 N_MSG

On Mon, Aug 27, 2018 at 07:33:40PM +0200, Greg Kroah-Hartman wrote:
> On Thu, Aug 23, 2018 at 10:58:09PM +0530, Nishad Kamdar wrote:
> > This patch removes the dead code for N_MSG().
> > 
> > Signed-off-by: Nishad Kamdar <nishadkamdar@...il.com>
> > ---
> > Changes in v5:
> >   - Remove commented code for N_MSG()
> > ---
> >  drivers/staging/mt7621-mmc/dbg.h | 8 --------
> >  1 file changed, 8 deletions(-)
> > 
> > diff --git a/drivers/staging/mt7621-mmc/dbg.h b/drivers/staging/mt7621-mmc/dbg.h
> > index 2f2c56b73987..6f6b4505337f 100644
> > --- a/drivers/staging/mt7621-mmc/dbg.h
> > +++ b/drivers/staging/mt7621-mmc/dbg.h
> > @@ -103,14 +103,6 @@ do { \
> >  #endif /* end of +++ */
> >  
> >  #define N_MSG(evt, fmt, args...)
> > -/*
> > -do {    \
> > -    if ((DBG_EVT_##evt) & sd_debug_zone[host->id]) { \
> > -        printk(KERN_ERR TAG"%d -> "fmt" <- %s() : L<%d> PID<%s><0x%x>\n", \
> > -            host->id,  ##args , __FUNCTION__, __LINE__, current->comm, current->pid);	\
> > -    } \
> > -} while(0)
> > -*/
> >  
> 
> So what are we supposed to do with a macro that defines nothing now?
> Please delete it and all users of it at the same time.
> 
> thanks,
> 
> greg k-h

Ok, I'll do that.

thanks for the review.

regards,
nishad