linux-kernel - Re: [PATCH] MIPS: BCM47XX: Enable USB power on Netgear WNDR3400v3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180829221558.bwaamm35cvgtfea5@pburton-laptop>
Date:   Wed, 29 Aug 2018 15:15:58 -0700
From:   Paul Burton <paul.burton@...s.com>
To:     Tuomas Tynkkynen <tuomas.tynkkynen@....fi>
Cc:     Hauke Mehrtens <hauke@...ke-m.de>,
        Rafał Miłecki <zajec5@...il.com>,
        linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: BCM47XX: Enable USB power on Netgear WNDR3400v3

Hi Tuomas,

On Sun, Aug 19, 2018 at 10:20:23PM +0300, Tuomas Tynkkynen wrote:
> Setting GPIO 21 high seems to be required to enable power to USB ports
> on the WNDR3400v3. As there is already similar code for WNR3500L,
> make the existing USB power GPIO code generic and use that.
> 
> Signed-off-by: Tuomas Tynkkynen <tuomas.tynkkynen@....fi>
> ---
>  arch/mips/bcm47xx/workarounds.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

It'd be nice to see this stuff move towards DT, and configuring a GPIO
to enable power doesn't seem so much a workaround as a normal expected
part of operation.

But I've applied this to mips-next for 4.20 since it doesn't really make
things any worse for now...

Thanks,
    Paul