lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Aug 2018 20:17:34 +0000 From: Pasha Tatashin <Pavel.Tatashin@...rosoft.com> To: David Hildenbrand <david@...hat.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> CC: "linux-mm@...ck.org" <linux-mm@...ck.org>, Andrew Morton <akpm@...ux-foundation.org>, Michal Hocko <mhocko@...e.com>, Vlastimil Babka <vbabka@...e.cz>, Stephen Rothwell <sfr@...b.auug.org.au>, Pavel Tatashin <pasha.tatashin@...cle.com>, Kemi Wang <kemi.wang@...el.com>, David Rientjes <rientjes@...gle.com>, Jia He <jia.he@...-semitech.com>, Oscar Salvador <osalvador@...e.de>, Petr Tesarik <ptesarik@...e.com>, Andrey Ryabinin <aryabinin@...tuozzo.com>, Dan Williams <dan.j.williams@...el.com>, Mathieu Malaterre <malat@...ian.org>, Baoquan He <bhe@...hat.com>, Wei Yang <richard.weiyang@...il.com>, Ross Zwisler <zwisler@...nel.org>, "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com> Subject: Re: [PATCH v1 1/5] mm/memory_hotplug: drop intermediate __offline_pages I guess the wrap was done because of __ref, but no reason to have this wrap. So looks good to me. Reviewed-by: Pavel Tatashin <pavel.tatashin@...rosoft.com> On 8/16/18 6:06 AM, David Hildenbrand wrote: > Let's avoid this indirection and just call the function offline_pages(). > > Signed-off-by: David Hildenbrand <david@...hat.com> > --- > mm/memory_hotplug.c | 13 +++---------- > 1 file changed, 3 insertions(+), 10 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 6a2726920ed2..090cf474de87 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1589,10 +1589,10 @@ static void node_states_clear_node(int node, struct memory_notify *arg) > node_clear_state(node, N_MEMORY); > } > > -static int __ref __offline_pages(unsigned long start_pfn, > - unsigned long end_pfn) > +/* Must be protected by mem_hotplug_begin() or a device_lock */ > +int offline_pages(unsigned long start_pfn, unsigned long nr_pages) > { > - unsigned long pfn, nr_pages; > + unsigned long pfn, end_pfn = start_pfn + nr_pages; > long offlined_pages; > int ret, node; > unsigned long flags; > @@ -1612,7 +1612,6 @@ static int __ref __offline_pages(unsigned long start_pfn, > > zone = page_zone(pfn_to_page(valid_start)); > node = zone_to_nid(zone); > - nr_pages = end_pfn - start_pfn; > > /* set above range as isolated */ > ret = start_isolate_page_range(start_pfn, end_pfn, > @@ -1700,12 +1699,6 @@ static int __ref __offline_pages(unsigned long start_pfn, > undo_isolate_page_range(start_pfn, end_pfn, MIGRATE_MOVABLE); > return ret; > } > - > -/* Must be protected by mem_hotplug_begin() or a device_lock */ > -int offline_pages(unsigned long start_pfn, unsigned long nr_pages) > -{ > - return __offline_pages(start_pfn, start_pfn + nr_pages); > -} > #endif /* CONFIG_MEMORY_HOTREMOVE */ > > /** >
Powered by blists - more mailing lists