lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 30 Aug 2018 11:28:08 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Nicholas Krause <xerofoify@...il.com>
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        keescook@...omium.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging:fwserial:Fix parentheses alignment in fwserial.c

On Wed, Aug 29, 2018 at 06:03:26PM -0400, Nicholas Krause wrote:
> Fix a checkpatch warning for the file, fwserial.c that warns about
> alignment between parentheses and the line belows code not being
> properly aligned with each other.
> 
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---
>  drivers/staging/fwserial/fwserial.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c
> index fa0dd425b454..f9fcabe7afa1 100644
> --- a/drivers/staging/fwserial/fwserial.c
> +++ b/drivers/staging/fwserial/fwserial.c
> @@ -1328,7 +1328,7 @@ static int fwtty_break_ctl(struct tty_struct *tty, int state)
>  	if (state == -1) {
>  		set_bit(STOP_TX, &port->flags);
>  		ret = wait_event_interruptible_timeout(port->wait_tx,
> -					       !test_bit(IN_TX, &port->flags),
> +						       !test_bit(IN_TX, &port->flags),
>  					       10);

Now it goes over 80 characters and the "10);" isn't aligned properly.
The original is fine.

regards,
dan carpenter

Powered by blists - more mailing lists