linux-kernel - Re: [PATCH net-next 1/5] pppoe: fix PPPOEIOCSFWD compat handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180830110453.GC1473@alphalink.fr>
Date:   Thu, 30 Aug 2018 13:04:53 +0200
From:   Guillaume Nault <g.nault@...halink.fr>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     paulus@...ba.org, linux-ppp@...r.kernel.org,
        netdev@...r.kernel.org, mitch@...oth.com, mostrows@...thlink.net,
        jchapman@...alix.com, xeb@...l.ru, davem@...emloft.net,
        viro@...iv.linux.org.uk, y2038@...ts.linaro.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 1/5] pppoe: fix PPPOEIOCSFWD compat handling

On Wed, Aug 29, 2018 at 04:03:26PM +0200, Arnd Bergmann wrote:
> Support for handling the PPPOEIOCSFWD ioctl in compat mode was added in
> linux-2.5.69 along with hundreds of other commands, but was always broken
> sincen only the structure is compatible, but the command number is not,
> due to the size being sizeof(size_t), or at first sizeof(sizeof((struct
> sockaddr_pppox)), which is different on 64-bit architectures.
> 
And the implementation was broken until 2016 (see 29e73269aa4d ("pppoe:
fix reference counting in PPPoE proxy")), and nobody ever noticed. I
should probably have removed this ioctl entirely instead of fixing it.
Clearly, it has never been used.

If you think it's worth fixing (as opposed to dropping this ioctl or
its compat mode), then,
Acked-by: Guillaume Nault <g.nault@...halink.fr>