linux-kernel - Re: [PATCHv2] iscsi-target: Don't use stack buffer for scatterlist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq18t4o5cgh.fsf@oracle.com>
Date:   Thu, 30 Aug 2018 07:19:10 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Laura Abbott <labbott@...hat.com>
Cc:     "Nicholas A. Bellinger" <nab@...ux-iscsi.org>,
        Bart Van Assche <bart.vanassche@....com>,
        Hannes Reinecke <hare@...e.com>,
        Mike Christie <mchristi@...hat.com>,
        Maurizio Lombardi <mlombard@...hat.com>,
        target-devel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2] iscsi-target: Don't use stack buffer for scatterlist


> Fedora got a bug report of a crash with iSCSI:
>
> kernel BUG at include/linux/scatterlist.h:143!
> ...
> RIP: 0010:iscsit_do_crypto_hash_buf+0x154/0x180 [iscsi_target_mod]
> ...
>  Call Trace:
>   ? iscsi_target_tx_thread+0x200/0x200 [iscsi_target_mod]
>   iscsit_get_rx_pdu+0x4cd/0xa90 [iscsi_target_mod]
>   ? native_sched_clock+0x3e/0xa0
>   ? iscsi_target_tx_thread+0x200/0x200 [iscsi_target_mod]
>   iscsi_target_rx_thread+0x81/0xf0 [iscsi_target_mod]
>   kthread+0x120/0x140
>   ? kthread_create_worker_on_cpu+0x70/0x70
>   ret_from_fork+0x3a/0x50
>
> This is a BUG_ON for using a stack buffer with a scatterlist.  There
> are two cases that trigger this bug. Switch to using a dynamically
> allocated buffer for one case and do not assign a NULL buffer in
> another case.

Mike: Please review. Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering