lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Aug 2018 13:59:11 +0200 From: Vitaly Kuznetsov <vkuznets@...hat.com> To: gregkh@...uxfoundation.org, kys@...uxonhyperv.com Cc: linux-kernel@...r.kernel.org, devel@...uxdriverproject.org, olaf@...fle.de, apw@...onical.com, jasowang@...hat.com, sthemmin@...rosoft.com, Michael.H.Kelley@...rosoft.com, kys@...rosoft.com, stable@...r.kernel.org Subject: Re: [PATCH] vmbus: don't return values for uninitalized channels kys@...uxonhyperv.com writes: > From: Stephen Hemminger <stephen@...workplumber.org> > > For unsupported device types, the vmbus channel ringbuffer is never > initialized, and therefore reading the sysfs files will return garbage > or cause a kernel OOPS. > > Fixes: c2e5df616e1a ("vmbus: add per-channel sysfs info") > > Signed-off-by: Stephen Hemminger <sthemmin@...rosoft.com> > Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com> > Cc: <stable@...r.kernel.org> # 4.15 As this is also marked for stable, any chance we can get it in 4.19? Or at least in char-misc-next? > --- > drivers/hv/vmbus_drv.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c > index e6d8fdac6d8b..4bbc420d1213 100644 > --- a/drivers/hv/vmbus_drv.c > +++ b/drivers/hv/vmbus_drv.c > @@ -1368,6 +1368,9 @@ static ssize_t vmbus_chan_attr_show(struct kobject *kobj, > if (!attribute->show) > return -EIO; > > + if (chan->state != CHANNEL_OPENED_STATE) > + return -EINVAL; > + > return attribute->show(chan, buf); > } Thanks, -- Vitaly
Powered by blists - more mailing lists