linux-kernel - Re: [PATCH v2] serial: 8250_of: Fix for lack of interrupt support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+UDvL9+3RT8wKXyobXJx14MmcS4X0B1hVghQHXttGAmQ@mail.gmail.com>
Date:   Thu, 30 Aug 2018 09:19:29 -0500
From:   Rob Herring <robh@...nel.org>
To:     John Garry <john.garry@...wei.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Alexander Sverdlin <alexander.sverdlin@...ia.com>,
        Jiri Slaby <jslaby@...e.com>, Joel Stanley <joel@....id.au>,
        kurt@...utronix.de,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linuxarm <linuxarm@...wei.com>
Subject: Re: [PATCH v2] serial: 8250_of: Fix for lack of interrupt support

On Thu, Aug 30, 2018 at 4:10 AM John Garry <john.garry@...wei.com> wrote:
>
> In commit c58caaab3bf8 ("serial: 8250: of: Defer probe on missing IRQ"), a
> check was added for the UART driver being probed prior to the parent IRQ
> controller.
>
> Unfortunately this breaks certain boards which have no interrupt support,
> like Huawei D03.
>
> Indeed, the 8250 DT bindings state that interrupts should be supported -
> not must.
>
> To fix, switch from irq_of_parse_and_map() to of_irq_get(), which
> does relay whether the IRQ host controller domain is not ready, i.e.
> defer probe, instead of assuming it.

Good, one less user of irq_of_parse_and_map().

Reviewed-by: Rob Herring <robh@...nel.org>