lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Aug 2018 08:20:32 -0600 From: "wufan" <wufan@...eaurora.org> To: "'Borislav Petkov'" <bp@...en8.de> Cc: <mchehab@...nel.org>, <james.morse@....com>, <baicar.tyler@...il.com>, <linux-edac@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>, "'Kani, Toshi'" <toshi.kani@....com> Subject: RE: [PATCH] EDAC, ghes: use CPER module handles to locate DIMMs Hi Boris, > If we're going to do this, it needs to be tested on an x86 box which loads > ghes_edac. Adding Toshi to Cc. > > Otherwise it must remain ARM-specific. Toshi it would be great if you can help! I'll also test the change in x86 but not sure if the firmware updates module_handle. > > +static int ghes_edac_dimm_index(u16 handle) > > get_dimm_smbios_handle() This function returns an index. So how about get_dimm_smbios_index()? > > +{ > > + struct mem_ctl_info *mci; > > + int i; > > + > > + if (!ghes_pvt) > > + return -1; > > You don't need that test. Will remove. > > + > > + mci = ghes_pvt->mci; > > + > > + if (!mci) > > + return -1; > > Ditto. Will remove Thanks, Fan
Powered by blists - more mailing lists