lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Aug 2018 16:26:06 +0200 (CEST) From: Thomas Gleixner <tglx@...utronix.de> To: Prarit Bhargava <prarit@...hat.com> cc: linux-kernel@...r.kernel.org, Mark Salter <msalter@...hat.com>, Al Stone <ahs3@...hat.com>, "Rafael J. Wysocki" <rjw@...ysocki.net>, Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>, x86@...nel.org, Petr Mladek <pmladek@...e.com>, Sergey Senozhatsky <sergey.senozhatsky@...il.com>, Steven Rostedt <rostedt@...dmis.org>, Kees Cook <keescook@...omium.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-pm@...r.kernel.org Subject: Re: [PATCH v3] console: Add console=spcr option On Wed, 29 Aug 2018, Prarit Bhargava wrote: > + > +void __init arch_console_setup(void) > +{ > + int ret; > + > + ret = acpi_parse_spcr(false, true); > + if (ret) > + pr_err(PREFIX "ERROR: SPCR console is not enabled (%d)\n", ret); > +} Why does this require yet another arch/weak function? > /* > * Set up a console. Called via do_early_param() in init/main.c > * for each "console=" parameter in the boot command line. > @@ -2107,6 +2112,11 @@ static int __init console_setup(char *str) > char *s, *options, *brl_options = NULL; > int idx; > > + if (!strcmp(str, "spcr")) { > + arch_console_setup(); > + return 1; And this gets added to everything and the world whether it's needed/supported or not. Why can't we simply register the SPCR console as we do with any other console when it is detected? If we can't for some real good reason then there is no need to invoke acpi_parse_spcr() twice. We simply can store the fact that it got selected and use that information in acpi_boot_init(). Thanks, tglx
Powered by blists - more mailing lists