linux-kernel - Re: [PATCH] hv_netvsc: Fix a deadlock by getting rtnl_lock earlier in netvsc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180829.190839.1082082323658260994.davem@davemloft.net>
Date:   Wed, 29 Aug 2018 19:08:39 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     decui@...rosoft.com
Cc:     kys@...rosoft.com, haiyangz@...rosoft.com, sthemmin@...rosoft.com,
        netdev@...r.kernel.org, devel@...uxdriverproject.org,
        linux-kernel@...r.kernel.org, olaf@...fle.de, apw@...onical.com,
        jasowang@...hat.com, vkuznets@...hat.com,
        marcelo.cerri@...onical.com, jopoulso@...rosoft.com
Subject: Re: [PATCH] hv_netvsc: Fix a deadlock by getting rtnl_lock earlier
 in netvsc_probe()

From: Dexuan Cui <decui@...rosoft.com>
Date: Thu, 30 Aug 2018 00:58:48 +0000

>> From: David Miller <davem@...emloft.net>
>> Sent: Wednesday, August 29, 2018 17:49
>> 
>> From: Dexuan Cui <decui@...rosoft.com>
>> Date: Wed, 22 Aug 2018 21:20:03 +0000
>> 
>> > ---
>> >  drivers/net/hyperv/netvsc_drv.c | 11 ++++++++++-
>> >  1 file changed, 10 insertions(+), 1 deletion(-)
>> >
>> >
>> > FYI: these are the related 3 paths which show the deadlock:
>> 
>> This incredibly useful information belongs in the commit log
>> message, and therefore before the --- and signoffs.
> 
> Hi David,
> I was afraid the call-traces are too detailed. :-)
> 
> Can you please move the info to before the --- line?
> 
> Or, should I resend the patch with the commit log updated?

Please resend.