linux-kernel - Re: [PATCH] thermal: Convert to using %pOFn instead of device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ac2580ab-e65a-ed54-708b-871bf0a3305d@linaro.org>
Date:   Thu, 30 Aug 2018 16:58:16 +0200
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Rob Herring <robh@...nel.org>, linux-kernel@...r.kernel.org
Cc:     Zhang Rui <rui.zhang@...el.com>,
        Eduardo Valentin <edubezval@...il.com>,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH] thermal: Convert to using %pOFn instead of
 device_node.name

On 28/08/2018 03:52, Rob Herring wrote:
> In preparation to remove the node name pointer from struct device_node,
> convert printf users to use the %pOFn format specifier.
> 
> Cc: Zhang Rui <rui.zhang@...el.com>
> Cc: Eduardo Valentin <edubezval@...il.com>
> Cc: Daniel Lezcano <daniel.lezcano@...aro.org>
> Cc: linux-pm@...r.kernel.org
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---

Acked-by: Daniel Lezcano <daniel.lezcano@...aro.org>

>  drivers/thermal/of-thermal.c    | 10 +++++-----
>  drivers/thermal/qoriq_thermal.c |  4 ++--
>  2 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c
> index 977a8307fbb1..e201ae1c382f 100644
> --- a/drivers/thermal/of-thermal.c
> +++ b/drivers/thermal/of-thermal.c
> @@ -483,8 +483,8 @@ thermal_zone_of_sensor_register(struct device *dev, int sensor_id, void *data,
>  		if (sensor_specs.args_count >= 1) {
>  			id = sensor_specs.args[0];
>  			WARN(sensor_specs.args_count > 1,
> -			     "%s: too many cells in sensor specifier %d\n",
> -			     sensor_specs.np->name, sensor_specs.args_count);
> +			     "%pOFn: too many cells in sensor specifier %d\n",
> +			     sensor_specs.np, sensor_specs.args_count);
>  		} else {
>  			id = 0;
>  		}
> @@ -960,8 +960,8 @@ int __init of_parse_thermal_zones(void)
>  
>  		tz = thermal_of_build_thermal_zone(child);
>  		if (IS_ERR(tz)) {
> -			pr_err("failed to build thermal zone %s: %ld\n",
> -			       child->name,
> +			pr_err("failed to build thermal zone %pOFn: %ld\n",
> +			       child,
>  			       PTR_ERR(tz));
>  			continue;
>  		}
> @@ -995,7 +995,7 @@ int __init of_parse_thermal_zones(void)
>  						    tz->passive_delay,
>  						    tz->polling_delay);
>  		if (IS_ERR(zone)) {
> -			pr_err("Failed to build %s zone %ld\n", child->name,
> +			pr_err("Failed to build %pOFn zone %ld\n", child,
>  			       PTR_ERR(zone));
>  			kfree(tzp);
>  			kfree(ops);
> diff --git a/drivers/thermal/qoriq_thermal.c b/drivers/thermal/qoriq_thermal.c
> index c866cc165960..1fa132fc316b 100644
> --- a/drivers/thermal/qoriq_thermal.c
> +++ b/drivers/thermal/qoriq_thermal.c
> @@ -129,8 +129,8 @@ static int qoriq_tmu_get_sensor_id(void)
>  	if (sensor_specs.args_count >= 1) {
>  		id = sensor_specs.args[0];
>  		WARN(sensor_specs.args_count > 1,
> -				"%s: too many cells in sensor specifier %d\n",
> -				sensor_specs.np->name, sensor_specs.args_count);
> +				"%pOFn: too many cells in sensor specifier %d\n",
> +				sensor_specs.np, sensor_specs.args_count);
>  	} else {
>  		id = 0;
>  	}
> 


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog