lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 30 Aug 2018 17:12:54 +0200
From:   Frederic Weisbecker <>
To:     Thomas Gleixner <>
Cc:     John Crispin <>,
        LKML <>,
        Ingo Molnar <>,
        Anna-Maria Gleixner <>,
        Greg Kroah-Hartman <>,
Subject: Re: [PATCH stable] tick/nohz: Prevent bogus softirq pending warning

On Thu, Aug 30, 2018 at 05:05:19PM +0200, Thomas Gleixner wrote:
> Commit 0a0e0829f990 ("nohz: Fix missing tick reprogram when interrupting an
> inline softirq") got backported to stable trees and now causes the NOHZ
> softirq pending warning to trigger. It's not an upstream issue as the NOHZ
> update logic has been changed there.
> The problem is when a softirq disabled section gets interrupted and on
> return from interrupt the tick/nohz state is evaluated, which then can
> observe pending soft interrupts. These soft interrupts are legitimately
> pending because they cannot be processed as long as soft interrupts are
> disabled and the interrupted code will correctly process them when soft
> interrupts are reenabled.
> Add a check for softirqs disabled to the pending check to prevent the
> warning.
> Reported-by: Grygorii Strashko <>
> Reported-by: John Crispin <>
> Signed-off-by: Thomas Gleixner <>
> Tested-by: Grygorii Strashko <>
> Tested-by: John Crispin <>

Acked-by: Frederic Weisbecker <>

Thanks for cooking the patch!

Powered by blists - more mailing lists