lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Aug 2018 18:13:58 +0300 From: Pavel Zemlyanoy <zemlyanoy@...ras.ru> To: Gao Xiang <gaoxiang25@...wei.com>, Chao Yu <yuchao0@...wei.com> Cc: Pavel Zemlyanoy <zemlyanoy@...ras.ru>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-erofs@...ts.ozlabs.org, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org, ldv-project@...uxtesting.org Subject: [PATCH 2/6] staging: erofs: formatting fix to NULL comparison This patch does not change the logic, it only corrects the formatting and checkpatch checks by to NULL comparison. The patch fixes 5 checks of type: "Comparison to NULL could be written". Signed-off-by: Pavel Zemlyanoy <zemlyanoy@...ras.ru> --- drivers/staging/erofs/unzip_vle_lz4.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/erofs/unzip_vle_lz4.c b/drivers/staging/erofs/unzip_vle_lz4.c index f9e6b78..54da72a 100644 --- a/drivers/staging/erofs/unzip_vle_lz4.c +++ b/drivers/staging/erofs/unzip_vle_lz4.c @@ -42,8 +42,8 @@ int z_erofs_vle_plain_copy(struct page **compressed_pages, struct page *page = pages[i]; void *dst; - if (page == NULL) { - if (src != NULL) { + if (!page) { + if (src) { if (!mirrored[j]) kunmap_atomic(src); src = NULL; @@ -64,7 +64,7 @@ int z_erofs_vle_plain_copy(struct page **compressed_pages, } if (i) { - if (src == NULL) + if (!src) src = mirrored[i-1] ? percpu_data + (i-1) * PAGE_SIZE : kmap_atomic(compressed_pages[i-1]); @@ -92,7 +92,7 @@ int z_erofs_vle_plain_copy(struct page **compressed_pages, kunmap_atomic(dst); } - if (src != NULL && !mirrored[j]) + if (src && !mirrored[j]) kunmap_atomic(src); preempt_enable(); @@ -136,7 +136,7 @@ int z_erofs_vle_unzip_fast_percpu(struct page **compressed_pages, for (i = 0; i < nr_pages; ++i) { j = min((unsigned int)PAGE_SIZE - pageofs, outlen); - if (pages[i] != NULL) { + if (pages[i]) { if (ret < 0) SetPageError(pages[i]); else if (clusterpages == 1 && pages[i] == compressed_pages[0]) -- 2.7.4
Powered by blists - more mailing lists