linux-kernel - Re: [PATCH] device-dax: Convert variable to vm_fault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFqt6zbz6bb55BYvWHq4PwH64hUWQ8DnGV9U3hB3Mg4AO3PwjQ@mail.gmail.com>
Date:   Thu, 30 Aug 2018 21:10:35 +0530
From:   Souptick Joarder <jrdr.linux@...il.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Dan Williams <dan.j.williams@...el.com>, dave.jiang@...el.com,
        zwisler@...nel.org, vishal.l.verma@...el.com,
        linux-nvdimm <linux-nvdimm@...ts.01.org>,
        linux-kernel@...r.kernel.org, Matthew Wilcox <willy@...radead.org>
Subject: Re: [PATCH] device-dax: Convert variable to vm_fault_t type

On Thu, Aug 30, 2018 at 9:05 PM Souptick Joarder <jrdr.linux@...il.com> wrote:
>
> As part of commit 226ab561075f ("device-dax: Convert to
> vmf_insert_mixed and vm_fault_t") in 4.19-rc1,
> 'rc' was not converted to vm_fault_t. Now converted.
>
> Signed-off-by: Souptick Joarder <jrdr.linux@...il.com>

Sorry, I missed this initially.
> ---
>  drivers/dax/device.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dax/device.c b/drivers/dax/device.c
> index 6fd4608..bbe4d72 100644
> --- a/drivers/dax/device.c
> +++ b/drivers/dax/device.c
> @@ -392,7 +392,8 @@ static vm_fault_t dev_dax_huge_fault(struct vm_fault *vmf,
>  {
>         struct file *filp = vmf->vma->vm_file;
>         unsigned long fault_size;
> -       int rc, id;
> +       vm_fault_t rc = VM_FAULT_SIGBUS;
> +       int id;
>         pfn_t pfn;
>         struct dev_dax *dev_dax = filp->private_data;
>
> --
> 1.9.1
>