lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Aug 2018 09:40:57 -0700 From: Tony Lindgren <tony@...mide.com> To: Pavel Machek <pavel@....cz> Cc: linux-leds@...r.kernel.org, jacek.anaszewski@...il.com, kernel list <linux-kernel@...r.kernel.org>, linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, linux-omap@...r.kernel.org, sre@...nel.org, nekit1000@...il.com, mpartap@....net, merlijn@...zup.org Subject: Re: [PATCH] leds: add TI LMU backlight driver * Pavel Machek <pavel@....cz> [180830 08:26]: > This adds backlight support for the following TI LMU > chips: LM3532, LM3631, LM3632, LM3633, LM3695 and LM3697. ... > +struct ti_lmu_bank { > + struct device *dev; > + int bank_id; > + const struct ti_lmu_bl_cfg *cfg; > + struct ti_lmu *lmu; > + const char *label; > + int leds; > + int current_brightness; > + u32 default_brightness; > + u32 ramp_up_msec; > + u32 ramp_down_msec; > + > + struct notifier_block nb; > + > + struct led_classdev *led; > +}; > + > +static int ti_lmu_bl_enable(struct ti_lmu_bank *lmu_bank, bool enable) > +{ > + struct regmap *regmap = lmu_bank->lmu->regmap; > + unsigned long enable_time = lmu_bank->cfg->reginfo->enable_usec; > + u8 *reg = lmu_bank->cfg->reginfo->enable; > + u8 mask = BIT(lmu_bank->bank_id); > + u8 val = (enable == true) ? mask : 0; > + int ret; > + > + if (!reg) > + return -EINVAL; > + > + ret = regmap_update_bits(regmap, *reg, mask, val); > + if (ret) > + return ret; > + > + if (enable_time > 0) > + usleep_range(enable_time, enable_time + 100); > + > + return 0; > +} If it's a led driver, should you just s/ti_lmu_bl/ti_lmu_led/g? Regards, Tony
Powered by blists - more mailing lists