lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Thu, 30 Aug 2018 13:32:20 -0400
From:   Ray Clinton <>
Subject: [PATCH 3/4] staging: comedi: Correct multiline dereference as per TODO

Using I was able to find a multiline dereference which goes
again the coding style for the kernel. I'm still working on my email client so
the indentation looks bad here (in gmail) but the arguments for
ni_tio_set_mite_channel should go just under the opening (

Signed-off-by: Ray Clinton <>
 drivers/staging/comedi/drivers/ni_mio_common.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c
index 4dee2fc..5de3a20 100644
--- a/drivers/staging/comedi/drivers/ni_mio_common.c
+++ b/drivers/staging/comedi/drivers/ni_mio_common.c
@@ -723,9 +723,9 @@ static void ni_release_gpct_mite_channel(struct
comedi_device *dev,

                ni_set_bitfield(dev, NI_E_DMA_G0_G1_SEL_REG,
                                NI_E_DMA_G0_G1_SEL_MASK(gpct_index), 0);
-               ni_tio_set_mite_channel(&devpriv->
-                                       counter_dev->counters[gpct_index],
-                                       NULL);
+               ni_tio_set_mite_channel(
+                                  &devpriv->counter_dev->counters[gpct_index],
+                                  NULL);
        spin_unlock_irqrestore(&devpriv->mite_channel_lock, flags);

Powered by blists - more mailing lists