linux-kernel - Re: [RFC 3/3] stk1160: Use non-coherent buffers for USB transfers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180830175937.GB11521@infradead.org>
Date:   Thu, 30 Aug 2018 10:59:37 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Ezequiel Garcia <ezequiel@...labora.com>
Cc:     linux-media@...r.kernel.org, linux-usb@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Tomasz Figa <tfiga@...omium.org>,
        "Matwey V . Kornilov" <matwey@....msu.ru>,
        Alan Stern <stern@...land.harvard.edu>, kernel@...labora.com,
        Keiichi Watanabe <keiichiw@...omium.org>
Subject: Re: [RFC 3/3] stk1160: Use non-coherent buffers for USB transfers

> +	dma_sync_single_for_cpu(&urb->dev->dev, urb->transfer_dma,
> +		urb->transfer_buffer_length, DMA_FROM_DEVICE);

You can't ue dma_sync_single_for_cpu on non-coherent dma buffers,
which is one of the major issues with them.