linux-kernel - Re: [PATCH] perf annotate: Handle arm64 move instructions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 30 Aug 2018 15:38:36 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Thomas-Mich Richter <tmricht@...ux.ibm.com>
Cc:     Kim Phillips <kim.phillips@....com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Richter <tmricht@...ux.vnet.ibm.com>,
        Hendrik Brueckner <brueckner@...ux.vnet.ibm.com>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        perf group <linux-perf-users@...r.kernel.org>
Subject: Re: [PATCH] perf annotate: Handle arm64 move instructions

Em Tue, Aug 28, 2018 at 08:22:40AM +0200, Thomas-Mich Richter escreveu:
> On 08/27/2018 10:08 PM, Kim Phillips wrote:
> > Add default handler for non-jump instructions.  This really only has an
> > effect on instructions that compute a PC-relative address, such as 'adrp,'
> > as seen in these couple of examples:
> > 
> > BEFORE: adrp   x0, ffff20000aa11000 <kallsyms_token_index+0xce000>
> > AFTER:  adrp   x0, kallsyms_token_index+0xce000
> > 
> > BEFORE: adrp   x23, ffff20000ae94000 <__per_cpu_load>
> > AFTER:  adrp   x23, __per_cpu_load
> > 
> > The implementation is identical to that of s390, but with a slight
> > adjustment for objdump whitespace propagation (arm64 objdump puts
> > spaces after commas, whereas s390's presumably doesn't).
> > 
> > The mov__scnprintf() declaration is moved from s390's to arm64's
> > instructions.c because arm64's gets included before s390's.
> > 
> 
> Tested-by: Thomas Richter <tmricht@...ux.ibm.com>

Thanks, applied.

- Arnaldo