linux-kernel - Re: [PATCH v2] perf annotate: fix parsing aarch64 branch instructions after objdump update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 30 Aug 2018 15:47:06 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Kim Phillips <kim.phillips@....com>
Cc:     Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com>,
        Anton Blanchard <anton@...ba.org>,
        Robin Murphy <robin.murphy@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        Mark Rutland <mark.rutland@....com>,
        Peter Zijlstra <peterz@...radead.org>,
        Taeung Song <treeze.taeung@...il.com>,
        Ingo Molnar <mingo@...hat.com>, Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        perf group <linux-perf-users@...r.kernel.org>
Subject: Re: [PATCH v2] perf annotate: fix parsing aarch64 branch
 instructions after objdump update

Em Mon, Aug 27, 2018 at 12:53:40PM -0500, Kim Phillips escreveu:
> v2: address acme's comments:
>     - consolidate into a validate_comma()
>     - call from an additional couple of places necessary
>     - don't listen to checkpatch wrt reflowing jump__parse definition
>       line to less than 80 characters, just rm the __maybe_unused
>     - re-tested no diff on x86_64 and power arch, arm64 conditional
>       branches fixed.

Thanks for taking into account my comments, applied.

- Arnaldo