lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 30 Aug 2018 12:07:11 -0700
From:   Dave Hansen <dave.hansen@...el.com>
To:     Zhang Yi <yi.z.zhang@...ux.intel.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-nvdimm@...ts.01.org,
        pbonzini@...hat.com, dan.j.williams@...el.com,
        dave.jiang@...el.com, yu.c.zhang@...el.com, pagupta@...hat.com,
        david@...hat.com, jack@...e.cz, hch@....de
Cc:     linux-mm@...ck.org, rkrcmar@...hat.com, jglisse@...hat.com,
        yi.z.zhang@...el.com
Subject: Re: [PATCH V4 4/4] kvm: add a check if pfn is from NVDIMM pmem.

On 08/22/2018 03:58 AM, Zhang Yi wrote:
>  bool kvm_is_reserved_pfn(kvm_pfn_t pfn)
>  {
> -	if (pfn_valid(pfn))
> -		return PageReserved(pfn_to_page(pfn));
> +	struct page *page;
> +
> +	if (pfn_valid(pfn)) {
> +		page = pfn_to_page(pfn);
> +		return PageReserved(page) && !is_dax_page(page);
> +	}

This is in desperate need of commenting about what it is doing and why.

The changelog alone doesn't cut it.

Powered by blists - more mailing lists