lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 31 Aug 2018 15:58:34 +0800 From: Chen-Yu Tsai <wens@...e.org> To: LABBE Corentin <clabbe.montjoie@...il.com> Cc: Maxime Ripard <maxime.ripard@...tlin.com>, axboe@...nel.dk, Hans de Goede <hdegoede@...hat.com>, Kishon Vijay Abraham I <kishon@...com>, Mark Rutland <mark.rutland@....com>, Rob Herring <robh+dt@...nel.org>, devicetree <devicetree@...r.kernel.org>, linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, linux-ide@...r.kernel.org, linux-kernel <linux-kernel@...r.kernel.org>, linux-sunxi <linux-sunxi@...glegroups.com>, Icenowy Zheng <icenowy@...c.io> Subject: Re: [PATCH v4 09/13] ARM: dts: sun8i: r40: add sata node On Fri, Aug 31, 2018 at 3:56 PM Corentin Labbe <clabbe.montjoie@...il.com> wrote: > > On Fri, Aug 31, 2018 at 09:35:00AM +0200, Maxime Ripard wrote: > > On Thu, Aug 30, 2018 at 09:01:16PM +0200, Corentin Labbe wrote: > > > R40 have a sata controller which is the same as A20. > > > This patch adds a DT node for it. > > > > > > Signed-off-by: Icenowy Zheng <icenowy@...c.io> > > > Signed-off-by: Corentin Labbe <clabbe.montjoie@...il.com> > > > --- > > > arch/arm/boot/dts/sun8i-r40.dtsi | 23 +++++++++++++++++++++++ > > > 1 file changed, 23 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/sun8i-r40.dtsi b/arch/arm/boot/dts/sun8i-r40.dtsi > > > index 852c2ccc3268..d6b5820da850 100644 > > > --- a/arch/arm/boot/dts/sun8i-r40.dtsi > > > +++ b/arch/arm/boot/dts/sun8i-r40.dtsi > > > @@ -550,6 +550,29 @@ > > > #size-cells = <0>; > > > }; > > > > > > + ahci: sata@...8000 { > > > + compatible = "allwinner,sun8i-r40-ahci"; > > > + reg = <0x01c18000 0x1000>; > > > + interrupts = <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>; > > > + clocks = <&ccu CLK_BUS_SATA>, <&ccu CLK_SATA>; > > > + resets = <&ccu RST_BUS_SATA>; > > > + resets-name = "ahci"; > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + status = "disabled"; > > > + > > > + sata_port: sata-port@0 { > > > + reg = <0>; > > > + phys = <&sata_phy>; > > > + }; > > > + }; > > > + > > > + sata_phy: sata-phy@...80c0 { > > > + compatible = "allwinner,sun8i-r40-sata-phy"; > > > + reg = <0x1c180c0 0x200>; > > > > Overlapping devices in the DTS is not ok. > > > > I do the same than arch/arm/boot/dts/berlin2.dtsi (sata@...000 phy@...0a0) > But since it is not a good justification, it seems that regmap is my only solution ? Since you are effectively splitting one device node into two, you should adjust the original (ahci) device nodes register range. ChenYu
Powered by blists - more mailing lists