lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 31 Aug 2018 10:14:20 +0200 From: Daniel Lezcano <daniel.lezcano@...aro.org> To: Eduardo Valentin <edubezval@...il.com>, Amit Kucheria <amit.kucheria@...aro.org> Cc: linux-kernel@...r.kernel.org, rnayak@...eaurora.org, linux-arm-msm@...r.kernel.org, bjorn.andersson@...aro.org, smohanad@...eaurora.org, andy.gross@...aro.org, dianders@...omium.org, mka@...omium.org, Zhang Rui <rui.zhang@...el.com>, Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com>, linux-pm@...r.kernel.org, devicetree@...r.kernel.org Subject: Re: [PATCH v1 02/10] dt-bindings: thermal: Fix a typo in documentation On 25/08/2018 01:24, Eduardo Valentin wrote: > On Thu, Aug 09, 2018 at 06:02:34PM +0530, Amit Kucheria wrote: >> c(1) + x(1) was actually meant to be c(1) * x(1). >> >> While we're at it, add some brackets to make it nicer to read. >> >> Signed-off-by: Amit Kucheria <amit.kucheria@...aro.org> >> --- >> Documentation/devicetree/bindings/thermal/thermal.txt | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt >> index cc553f0952c5..751104213d08 100644 >> --- a/Documentation/devicetree/bindings/thermal/thermal.txt >> +++ b/Documentation/devicetree/bindings/thermal/thermal.txt >> @@ -152,7 +152,7 @@ Optional property: >> Elem size: one cell the sensors listed in the thermal-sensors property. >> Elem type: signed Coefficients defaults to 1, in case this property >> is not specified. A simple linear polynomial is used: >> - Z = c0 * x0 + c1 + x1 + ... + c(n-1) * x(n-1) + cn. >> + Z = (c0 * x0) + (c1 * x1) + ... + (c(n-1) * x(n-1)) + cn. > > To be honest, I would prefer if this looks like: > + Z = c0 * x0 + c1 * x1 + ... + c(n-1) * x(n-1) + cn. > > The extra bracketing seams unnecessary confusion I agree, the brackets don't change the computation ordering, they are pointless. -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
Powered by blists - more mailing lists